-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configuration to manage redirect on publish #358
Merged
fsbraun
merged 22 commits into
django-cms:master
from
fsbraun:feat/configurable-redirect
Dec 28, 2023
Merged
feat: Add configuration to manage redirect on publish #358
fsbraun
merged 22 commits into
django-cms:master
from
fsbraun:feat/configurable-redirect
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
==========================================
- Coverage 90.95% 90.84% -0.12%
==========================================
Files 72 72
Lines 2533 2546 +13
Branches 356 361 +5
==========================================
+ Hits 2304 2313 +9
- Misses 168 169 +1
- Partials 61 64 +3 ☔ View full report in Codecov by Sentry. |
@marksweb I've fixed the tests for this. For py3.12 they keep failing due to the django-app-helper dependency. |
marksweb
requested changes
Nov 22, 2023
marksweb
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, upon publishing a page (or other content object) the user is redirected to the version admin of that object. This is excellent for power users.
This PR adds the setting
DJANGOCMS_VERSIONING_ON_PUBLISH_REDIRECT
with three possible values:"published"
: Redirects to the objects.get_absolute_url()
(if available, preview endpoint otherwise). This is close to v3's behaviour and potentially a good setting for an occasional editor."preview"
: Redirects to the object's preview endpoint, just as most other user interactions."versions"
: Redirects to the object's version list (as before)The default is
"published"
.This is a draft PR. Tests will work, once #357 is merged.
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.