Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid unnecessary loading of actions.js asset into the toolbar #403

Merged
merged 3 commits into from
May 3, 2024
Merged

fix: Avoid unnecessary loading of actions.js asset into the toolbar #403

merged 3 commits into from
May 3, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Apr 24, 2024 •
edited
Loading

Description

As of django CMS 4.1.1, the actions.js asset needs not be loaded by the toolbar. This slightly improves the decoupling of versioning and django CMS core on the JS code base.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun marked this pull request as ready for review May 3, 2024 14:23
vinitkumar
vinitkumar approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@fsbraun fsbraun merged commit ec3e5b9 into master May 3, 2024
109 checks passed
@fsbraun fsbraun deleted the fix/remove-unused-actions-js branch October 29, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar