-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Django 5.0 and 5.1 #429
Conversation
get_queryset
signature for Django 5+ There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these test failures in the current codebase - I don't see anything here to start invalidating form data
I can only assume it's django-cms/django-cms#8041 which added the missing x frame options to the ChangePage form, and for some reason it stops the change form in the test to validate. |
@marksweb It's factory boy writing random data into the x frame options field which will not validate... |
I would like to double-check that this solves django-cms/django-cms#8044. |
OK, it turns out, django-cms/django-cms#8044 needs an additional fix in the core. This is ready to be merged. |
Description
Fixes #428 by adding the optional parameter
exlude_parameters
to theVersionedChangeList.get_queryset
method. IF provided it will be passed to thesuper().get_queryset
method, if not, it will be omitted (to work with Django 4.2).Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.