Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Django 5.0 and 5.1 #429

Merged
merged 13 commits into from
Oct 28, 2024
Merged

feat: add support for Django 5.0 and 5.1 #429

merged 13 commits into from
Oct 28, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Oct 20, 2024

Description

Fixes #428 by adding the optional parameter exlude_parameters to the VersionedChangeList.get_queryset method. IF provided it will be passed to the super().get_queryset method, if not, it will be omitted (to work with Django 4.2).

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun marked this pull request as ready for review October 20, 2024 15:56
@fsbraun fsbraun changed the title fix: Update get_queryset signature for Django 5+ feat: add support for Django 5.0 and 5.1 Oct 20, 2024
@fsbraun fsbraun requested a review from a team October 28, 2024 15:29
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these test failures in the current codebase - I don't see anything here to start invalidating form data

@fsbraun
Copy link
Member Author

fsbraun commented Oct 28, 2024

@marksweb That's interesting. I only updated the changlog. Must be something that changed in develop-4 during the last week; since the merge of f3803cb.

@fsbraun
Copy link
Member Author

fsbraun commented Oct 28, 2024

I can only assume it's django-cms/django-cms#8041 which added the missing x frame options to the ChangePage form, and for some reason it stops the change form in the test to validate.

@fsbraun
Copy link
Member Author

fsbraun commented Oct 28, 2024

@marksweb It's factory boy writing random data into the x frame options field which will not validate...

@fsbraun
Copy link
Member Author

fsbraun commented Oct 28, 2024

I would like to double-check that this solves django-cms/django-cms#8044.

@fsbraun
Copy link
Member Author

fsbraun commented Oct 28, 2024

OK, it turns out, django-cms/django-cms#8044 needs an additional fix in the core. This is ready to be merged.

@fsbraun fsbraun merged commit 07f9ccb into master Oct 28, 2024
97 checks passed
@fsbraun fsbraun deleted the fix/facet-support branch October 28, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 5 redefined get_queryset in ChangeList
3 participants