Recurring payments support #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 78.41% 78.50% +0.08%
==========================================
Files 36 37 +1
Lines 1978 2014 +36
==========================================
+ Hits 1551 1581 +30
- Misses 427 433 +6
Continue to review full report at Codecov.
|
PetrDlouhy
force-pushed
the
feature/recurring
branch
from
58e47b2 to
2e44782
Compare
PetrDlouhy
changed the title
|
I consider this code ready for review. |
Alir3z4
requested changes
Apr 13, 2020
Alir3z4
reviewed
Apr 13, 2020
Alir3z4
reviewed
Apr 13, 2020
PetrDlouhy
force-pushed
the
feature/recurring
branch
3 times, most recently
from
055e999 to
ed2b693
Compare
|
@Alir3z4 I fixed most of your requests and commented the rest of them. I have also written some info about recurring payments to the docs. I also realised, that we should not send reminders for recurring accounts. Although somebody might request other kind of reminders before recurring payment. |
PetrDlouhy
force-pushed
the
feature/recurring
branch
from
ed2b693 to
f1a30b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implements recurring payments according to #64.
The code should be complete, but might require some polishing. I would appreciate any feedback with this.
I am currently implementing recurring payments with PayU through
django-paymentsanddjango-plans-payments. The recurrence is induced by server (contrary to PayPal recurring payments), which means, that there is need to store recurring payment data as well as the card token.