Add information about the end date of plan into Order #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First and foremost, django-plans doesn't support subscription plans yet #64 Will your work include that as well ? |
|
@Alir3z4 No, I meant the plan order by subscription. This only enables tracking of history of plan renewals in current logic. |
PetrDlouhy
force-pushed
the
feature/order_usage_history
branch
2 times, most recently
from
5fdecd1 to
76b52eb
Compare
PetrDlouhy
changed the title
|
I think this is more or less complete, although it would need some review. I am removing the Work in progress status. |
PetrDlouhy
force-pushed
the
feature/order_usage_history
branch
2 times, most recently
from
2530163 to
5ce643e
Compare
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
- Coverage 76.9% 76.8% -0.11%
=========================================
Files 29 30 +1
Lines 1667 1677 +10
=========================================
+ Hits 1282 1288 +6
- Misses 385 389 +4
Continue to review full report at Codecov.
|
PetrDlouhy
force-pushed
the
feature/order_usage_history
branch
from
1ed9296 to
b9ef711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready yet. In current state it is meant to be basis for further discussion.
In my project, I would need to redistribute money from users paying for the subscription plans to the creators of content. The current state of
django-plansmodel is quite insufficient for this. It doesn't capture complete log of plans usage (from when to when was theOrderused extendPlan.This PR is my attempt to extend the model to be able to capture this. Please, comment if you think that this is in the right direction, or what would you recommend. I am not sure if it would work properly if there is a change of plan in middle the extension time.