Separate Task/Queue for SearchIndex #59 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrmm I saw the error: Obviously the comment flake can be fixed -- but what about the unused import? AFAIK we do actually have to import that for the settings to get populated. What change would you prefer me to make so it passes travis? |
|
@jobelenus this is from flake documentation. this may help for the warnings?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #59
Developed support for a specific Search Index to use a specific task path in order to leverage celery's queue routing to better manage resources (e.g. the number of workers) to complete certain real time indexes fast enough.
I also added the django app conf, since thats the new way to do things with the app loader. I also added Task class support of IGNORE_RESULTS via a setting.