Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored district parsing routine #118

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Refactored district parsing routine #118

merged 8 commits into from
Sep 4, 2023

Conversation

jupadin
Copy link
Contributor

@jupadin jupadin commented Aug 9, 2023

Change Types

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code Refactoring

Description

  • Instead of scraping the html content of each individual association, this PR uses the response of an PHP-Script, given the association id (bhv_id). The data returned by the script is handled as JSON.
  • Started testing this new routine by adding a unit test.
  • This partly improves the issue scrape new Portal instead of old one #77

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read CONTRIBUTING.md.
  • I have added tests to cover my changes.
  • (?) My tests run automatically.
  • All new and existing tests passed.

@jupadin jupadin requested a review from djbrown as a code owner August 9, 2023 08:32
@jupadin jupadin closed this Aug 16, 2023
@djbrown
Copy link
Owner

djbrown commented Aug 26, 2023

thanks for the @jupadin! I didn't know that SPO-Endpoint yet.
Why did you close this? I'd have a look into this 😉

@djbrown djbrown reopened this Sep 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@djbrown djbrown merged commit 8f8b9f1 into djbrown:master Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djbrown djbrown djbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jupadin @djbrown