replace dangerous dereference of reinterpret_cast with memcpy #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dangerous deference of reinterpret_cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Raspberry Pi Zero 2W, compiling in Release mode introduced an issue where trying to call
vehicle->subscribe->getValuecrashed the program onTOPIC_ALTITUDE_BAROMETERandTOPIC_ALTITUDE_FUSIONED.These issues appeared to be caused by the dereference of a
reinterpret_castcall, specifically when the destination type wasfloat32_t. A safer approach would be to usememcpyto simply grab the bytes from the buffer and copy them into a new stack variable. The Telemetry messages are so small that a single copy will not produce any significant performance penalty.If, for some reason,
reinterpret_castis necessary, I'd love to know why that is and how I can get around the program crash when compiling with optimization.