hotfix[whsiperASR]: Remove word_timestamp from getTranscriptionWhisperASR #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not supported by WhisperASR. Fixes djmango#52
|
Needs more work, mainly a git blame between the last known good version 3.1.6: e019f0e |
|
@dahifi did you test this? did it fix the issue? After looking into it further, I don't think this change will fix the issue, and I believe it would only break other functionality. Even without I recommend closing this PR. |
|
Closing in favor of #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not supported by WhisperASR. Fixes #52
I'm not actually sure whether the newer ASR versions support this, we can always add back with something that parses the toggle setting properly.