Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 9848 - Better diagnostic when basic type was not expected #14672

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Dec 4, 2022

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 4, 2022

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
9848 enhancement Better diagnostic when type declaration was not expected

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14672"

@ntrel ntrel marked this pull request as ready for review December 5, 2022 11:17
@ntrel
Copy link
Contributor Author

ntrel commented Dec 5, 2022

Azure OMF failing:

+ curl -fsSL -A 'DMD-CI curl 7.85.0 (x86_64-w64-mingw32) libcurl/7.85.0 OpenSSL/1.1.1q (Schannel) zlib/1.2.12 brotli/1.0.9 zstd/1.5.2 libidn2/2.3.3 libssh2/1.10.0 nghttp2/1.48.0' --retry 5 --retry-max-time 120 --connect-timeout 5 --speed-time 30 --speed-limit 1024 https://downloads.dlang.org/other/dm857c.zip -o dmc.zip
curl: (22) The requested URL returned error: 522
##[error]Cmd.exe exited with code '22'.

@RazvanN7 RazvanN7 merged commit 1bd34f5 into dlang:master Dec 5, 2022
@ntrel ntrel deleted the defer-type branch December 5, 2022 12:37
tim-dlang added a commit to tim-dlang/dparsergen that referenced this pull request Dec 29, 2024
A test in druntime uses `int*[0].init`: https://github.com/dlang/dmd/blob/fb07d990466f185c2adb19d320627c2723d3978a/druntime/src/core/internal/traits.d#L625
This was previously not allowed in the grammar.
DMD probably accepts it since this PR: dlang/dmd#14672

The generated parser is now also tested with DMD and druntime sources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants