Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CppRuntime_Clang/Gcc to CppRuntime_libcpp/libstdcpp. #16610

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

JohanEngelen
Copy link
Contributor

@JohanEngelen JohanEngelen commented Jun 22, 2024

Also adds libcpp and libstdcpp -target= option recognition.

https://forum.dlang.org/post/[email protected]

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 22, 2024

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24623 enhancement Rename version CppRuntime_Clang/Gcc to CppRuntime_libcpp/libstdcpp.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16610"

@JohanEngelen JohanEngelen changed the title Rename CppRuntime_Clang/Gcc to CppRuntime_libcpp/libstdcpp. Rename CppRuntime_Clang/Gcc to CppRuntime_libcpp/libstdcpp https://issues.dlang.org/show_bug.cgi?id=24546 . Jun 22, 2024
@JohanEngelen JohanEngelen changed the title Rename CppRuntime_Clang/Gcc to CppRuntime_libcpp/libstdcpp https://issues.dlang.org/show_bug.cgi?id=24546 . Rename CppRuntime_Clang/Gcc to CppRuntime_libcpp/libstdcpp. Jun 22, 2024
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry and a spec PR(done: dlang/dlang.org#3852).

Surely we should deprecate the old ones first before removing them to allow transition? and give the user notice that the old versions will now not be set.

I otherwise approve of this. Thanks!

…ibcpp/libstdcpp. Add libcpp and libstdcpp -target= option recognition.
@JohanEngelen
Copy link
Contributor Author

Surely we should deprecate the old ones first before removing them to allow transition? and give the user notice that the old versions will now not be set.

AFAICT there is no mechanism for deprecating version identifier names. But I've changed the code such that it still defines the old runtime names, such that it does not break any user code depending on it.

JohanEngelen added a commit to JohanEngelen/dlang.org that referenced this pull request Jun 22, 2024
@JohanEngelen JohanEngelen requested a review from ibuclaw as a code owner June 22, 2024 10:30
@JohanEngelen
Copy link
Contributor Author

Probably the problem is that d_do_test is compiled by the host compiler, not by the just-built compiler...

@dlang-bot dlang-bot merged commit 1917164 into dlang:master Jun 22, 2024
41 checks passed
dlang-bot pushed a commit to dlang/dlang.org that referenced this pull request Jun 22, 2024
Comment on lines -662 to +664
case "CppRuntime_Clang":
case "CppRuntime_libcpp":
case "CppRuntime_DigitalMars":
case "CppRuntime_Gcc":
case "CppRuntime_libstdcpp":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names are equally, if not more confusing as the original (ie: libcpp is the GCC C PreProcessing library).

libstdc++v3 refers to itself as (lib)stdcxx in code.

Needs a bit more thought.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ian

@JohanEngelen JohanEngelen deleted the cppruntime_rename branch June 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants