-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CppRuntime_Clang/Gcc to CppRuntime_libcpp/libstdcpp. #16610
Conversation
Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16610" |
a96f9f0
to
3bb9c49
Compare
3bb9c49
to
2bb7540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a changelog entry and a spec PR(done: dlang/dlang.org#3852).
Surely we should deprecate the old ones first before removing them to allow transition? and give the user notice that the old versions will now not be set.
I otherwise approve of this. Thanks!
…ibcpp/libstdcpp. Add libcpp and libstdcpp -target= option recognition.
2bb7540
to
349b493
Compare
AFAICT there is no mechanism for deprecating version identifier names. But I've changed the code such that it still defines the old runtime names, such that it does not break any user code depending on it. |
Probably the problem is that |
b4851b0
to
0e174c9
Compare
case "CppRuntime_Clang": | ||
case "CppRuntime_libcpp": | ||
case "CppRuntime_DigitalMars": | ||
case "CppRuntime_Gcc": | ||
case "CppRuntime_libstdcpp": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These names are equally, if not more confusing as the original (ie: libcpp is the GCC C PreProcessing library).
libstdc++v3 refers to itself as (lib)stdcxx in code.
Needs a bit more thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Ian
Also adds libcpp and libstdcpp -target= option recognition.
https://forum.dlang.org/post/[email protected]