Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the AUTH command #25

Merged
merged 2 commits into from
Jul 18, 2014
Merged

Support for the AUTH command #25

merged 2 commits into from
Jul 18, 2014

Conversation

dlecocq
Copy link
Owner

@dlecocq dlecocq commented Jul 17, 2014

This is not yet detailed in the TCP spec, but pynsq's implementation was used as a reference.

@b4hand
Copy link

b4hand commented Jul 17, 2014

It may also be useful to warn if AUTH is provided but TLS not requested. It may technically be allowed by the protocol, but in this day and age, it's probably better to just disallow it.

@jehiah
Copy link
Contributor

jehiah commented Jul 17, 2014

Auth as a protocol on the nsqd side is pretty flexible. It doesn't describe what fields are used for the auth decision, but exposes ip/port, auth_secret and the tls state to an authentication daemon for that decision.

@b4hand I know of existing work to implement auth using ident (to map a remote connection to a user) and I've used it for ip based ACL. In those cases it makes sense to allow auth regardless of TLS state. (nsqd does require an auth_secret, but i've just used . to trigger the auth).

warning on auth without TLS seems useful though

dlecocq pushed a commit that referenced this pull request Jul 18, 2014
Support for the AUTH command
@dlecocq dlecocq merged commit e514fd9 into master Jul 18, 2014
@dlecocq dlecocq deleted the dan/auth-support branch July 18, 2014 14:41
@jehiah jehiah mentioned this pull request Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants