Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial textinput size #470

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

alcpereira
Copy link
Contributor

Summary

When the filters are too long, the TextInput wraps into a new line with a visual artifact.
This might be an issue with BubbleTea itself, but let me know if I should try to fix it here or in BubbleTea.

I reused the same values as getInputWidth.

Note: This is my first Go and BubbleTea contribution 🎉

How did you test this change?

I reproduce the issue locally with the following settings:

prSections:
  - title: Very long PR filter
    filters: is:open very very very very very very very very very very very very very very very very very long review:required sort:created-asc

issuesSections:
  - title: Very long Issue filter
    filters: is:open very very very very very very very very very very very very very very very very very long review:required sort:created-asc

I tested the changes with both focusing on the search and without. Seems to work as expected.

Video

Before

Screen.Recording.2024-11-05.at.00.07.39.mov

After

Screen.Recording.2024-11-05.at.00.06.33.mov

@dlvhdr
Copy link
Owner

dlvhdr commented Nov 5, 2024

Thanks, it looks great!

@dlvhdr dlvhdr merged commit 2358d9b into dlvhdr:main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants