Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Munin multigraph #16

Merged
merged 4 commits into from
Oct 30, 2015
Merged

Munin multigraph #16

merged 4 commits into from
Oct 30, 2015

Conversation

Self-Perfection
Copy link
Contributor

Enhanced monitroing plugin for munin. Key changes:

  • co2mon and co2mon_temp are merged to single multigraph plugin co2mon
  • Don't store in munin database outdated values in case daemon is stopped/crashed

Running just one plugin to collect both sensors data instead of two
plugins uses less resources. And multigraph approach prevents code
duplication.
Makes fetch considerably faster.
munin expects that plugin reports values for all fields it has
configured during `config`, at least 'U'ndef.
(see http://munin-monitoring.org/wiki/PluginConcise)
Assume that CntR and Tamb values are outdated if heartbeat was updated
more than 60 seconds ago.
@dmage
Copy link
Owner

dmage commented Oct 27, 2015

lgtm
@maklaut you are the author of the current version of this plugin. Does this PR look good for you?

@maklaut
Copy link
Contributor

maklaut commented Oct 30, 2015

@dmage everything is ok.
@Self-Perfection Thanks!

dmage added a commit that referenced this pull request Oct 30, 2015
@dmage dmage merged commit df58994 into dmage:master Oct 30, 2015
@Self-Perfection Self-Perfection deleted the munin_multigraph branch October 30, 2015 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants