Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Fix broken CI #340

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Fix broken CI #340

merged 1 commit into from
Jun 6, 2018

Conversation

asitstands
Copy link
Contributor

The cpplint in CI is broken after dmlc/dmlc-core#396. Now dmlc-core/scripts/lint.py runs in python3 and this breaks mshadow's CI. This PR attempts to fix the broken CI by catching up the change in dmlc-core.

@asitstands asitstands changed the title Fix travis.yml to catch up dmlc-core Fix .travis.yml to catch up dmlc-core May 18, 2018
@asitstands asitstands changed the title Fix .travis.yml to catch up dmlc-core Fix broken CI May 20, 2018
@tqchen tqchen merged commit 5cf130a into dmlc:master Jun 6, 2018
@TaoLv
Copy link
Member

TaoLv commented Jul 18, 2018

I'm not sure. But do you think recent CI failure is related to this PR? @asitstands @tqchen
https://travis-ci.org/dmlc/mshadow/jobs/405193399

The command "pip3 install  --user  cpplint pylint" failed and exited with 2 during .

@asitstands
Copy link
Contributor Author

I guess that the failures are because ubuntu does not provide the latest version of pip (9 vs. 10). I tried pip3 install --upgrade pip (#350) but it does not work (https://travis-ci.org/dmlc/mshadow/builds/405211319?utm_source=github_status&utm_medium=notification). Any idea to install the latest pip in the CI environment?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants