Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support _estimator_type. #6582

Merged
merged 6 commits into from
Jan 8, 2021
Merged

Support _estimator_type. #6582

merged 6 commits into from
Jan 8, 2021

Conversation

trivialfis
Copy link
Member

For more info, see: https://scikit-learn.org/stable/developers/develop.html#estimator-types

@trivialfis trivialfis requested a review from hcho3 January 7, 2021 14:36
@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #6582 (b948de5) into master (b2246ae) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6582      +/-   ##
==========================================
+ Coverage   80.10%   80.21%   +0.11%     
==========================================
  Files          13       13              
  Lines        3604     3609       +5     
==========================================
+ Hits         2887     2895       +8     
+ Misses        717      714       -3     
Impacted Files Coverage Δ
python-package/xgboost/sklearn.py 89.34% <100.00%> (+0.33%) ⬆️
python-package/xgboost/tracker.py 93.98% <0.00%> (-1.13%) ⬇️
python-package/xgboost/dask.py 81.38% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2246ae...b948de5. Read the comment docs.

@trivialfis trivialfis merged commit f5ff90c into dmlc:master Jan 8, 2021
@trivialfis trivialfis deleted the estimator-type branch January 8, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] convert dask -> non-dask model
4 participants