Deprecate implicitly nullable parameter types

dmnlk · Dec 7, 2024 · 853ec91 · 853ec91
1 parent 2d9d4fd
commit 853ec91
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/Core.php b/src/Core.php
@@ -333,9 +333,9 @@ public static function doSleep(array $request)
      */
     public static function proxy(
         FutureArrayInterface $future,
-        callable $onFulfilled = null,
-        callable $onRejected = null,
-        callable $onProgress = null
+        ?callable $onFulfilled = null,
+        ?callable $onRejected = null,
+        ?callable $onProgress = null
     ) {
         return new FutureArray(
             $future->then($onFulfilled, $onRejected, $onProgress),

diff --git a/src/Future/BaseFutureTrait.php b/src/Future/BaseFutureTrait.php
@@ -39,8 +39,8 @@ trait BaseFutureTrait
      */
     public function __construct(
         PromiseInterface $promise,
-        callable $wait = null,
-        callable $cancel = null
+        ?callable $wait = null,
+        ?callable $cancel = null
     ) {
         $this->wrappedPromise = $promise;
         $this->waitfn = $wait;
@@ -81,9 +81,9 @@ public function promise()
      * @return PromiseInterface
      */
     public function then(
-        callable $onFulfilled = null,
-        callable $onRejected = null,
-        callable $onProgress = null
+        ?callable $onFulfilled = null,
+        ?callable $onRejected = null,
+        ?callable $onProgress = null
     ) {
         return $this->wrappedPromise->then($onFulfilled, $onRejected, $onProgress);
     }

diff --git a/src/Future/CompletedFutureValue.php b/src/Future/CompletedFutureValue.php
@@ -20,7 +20,7 @@ class CompletedFutureValue implements FutureInterface
      * @param \Exception $e      Error. Pass a GuzzleHttp\Ring\Exception\CancelledFutureAccessException
      *                           to mark the future as cancelled.
      */
-    public function __construct($result, \Exception $e = null)
+    public function __construct($result, ?\Exception $e = null)
     {
         $this->result = $result;
         $this->error = $e;
@@ -58,9 +58,9 @@ public function promise()
      * @return PromiseInterface
      */
     public function then(
-        callable $onFulfilled = null,
-        callable $onRejected = null,
-        callable $onProgress = null
+        ?callable $onFulfilled = null,
+        ?callable $onRejected = null,
+        ?callable $onProgress = null
     ) {
         return $this->promise()->then($onFulfilled, $onRejected, $onProgress);
     }