Skip to content

Commit

Permalink
Merge pull request #290 from dmurdoch/cransubmission
Browse files Browse the repository at this point in the history
Respond to CRAN rejection
  • Loading branch information
dmurdoch authored Jan 6, 2023
2 parents ed87cc5 + 2cb782f commit 9a8fa98
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: rgl
Version: 0.111.5
Version: 0.111.6
Title: 3D Visualization Using OpenGL
Authors@R: c(person("Duncan", "Murdoch", role = c("aut", "cre"),
email = "[email protected]"),
Expand Down
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# rgl 0.111.5
# rgl 0.111.6

## Minor changes

Expand All @@ -17,6 +17,8 @@ added.
* Similarly, `rgl.par3d.names` and `rgl.par3d.readonly`
contain lists of properties that may be set or queried
in `par3d()`.
* Made some examples conditional on interactive use
to save time on CRAN.

## Bug fixes

Expand Down
8 changes: 8 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
0.111.6

Two examples that triggered the time NOTES have been made
conditional on being run interactively.

The previous submission also had some connection errors to
URLs; I think those are false positives.

0.111.5

This is a fairly small update, triggered by a request from CRAN.
Expand Down
2 changes: 1 addition & 1 deletion man/play3d.Rd
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ of producing the output movie. It invisibly returns
open3d()
plot3d( cube3d(col = "green") )
M <- par3d("userMatrix")
if (!rgl.useNULL())
if (!rgl.useNULL() && interactive())
play3d( par3dinterp(times = (0:2)*0.5, userMatrix = list(M,
rotate3d(M, pi/2, 1, 0, 0),
rotate3d(M, pi/2, 0, 1, 0) ) ),
Expand Down
4 changes: 2 additions & 2 deletions man/spin3d.Rd
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ by this function.
# Spin one object
open3d()
plot3d(oh3d(col = "lightblue", alpha = 0.5))
if (!rgl.useNULL())
if (!rgl.useNULL() && interactive())
play3d(spin3d(axis = c(1, 0, 0), rpm = 30), duration = 2)

# Show spinning sprites, and rotate the whole view
Expand All @@ -59,7 +59,7 @@ f <- function(time) {
base = spin1(time)$userMatrix)$userMatrix)
spin1(time)
}
if (!rgl.useNULL())
if (!rgl.useNULL() && interactive())
play3d(f, duration = 2)
}
\keyword{ dplot }

0 comments on commit 9a8fa98

Please sign in to comment.