New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] rgl:::triangulateSimple fails with 3 Points #388

Closed

discoleo opened this issue Sep 21, 2023 · 0 comments · Fixed by #390

discoleo commented Sep 21, 2023

rgl:::triangulateSimple fails with 3 Points

Note: polygon3d calls rgl:::triangulateSimple;

The variable good is defined only inside the while-loop:
while ((m <- length(verts)) > 3) {...}

But this while-loop is skipped for 3 points, generating an error.

dmurdoch added a commit that referenced this issue


          3 vertices are always good. Fixes #388.

39ec200

dmurdoch mentioned this issue

3 vertices are always good. #390

Merged

dmurdoch closed this as completed in #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment