Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stomp.py less verbose #164

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Make stomp.py less verbose #164

merged 2 commits into from
Sep 13, 2022

Conversation

amaltaro
Copy link
Contributor

Workaround for dmwm/WMCore#11281

However, tomorrow I am going to suggest a PR upstream to the stomp.py project. So I suggest not to merge these changes until we can hear from the stomp.py developers.

automatically increase stomp log level by one level
@amaltaro
Copy link
Contributor Author

@mrceyhun I applied the changes you suggested, could you please have another look (already squashed with the 1st commit).

The 2nd commit fixes a couple of pylint errors reported such as:

E1205 L340: Too many arguments for logging format string (logging-too-many-args)

I ran a quick test and it seems to be working fine. For my own information, here is how we can patch the agents with this:

curl https://patch-diff.githubusercontent.com/raw/dmwm/CMSMonitoring/pull/164.patch | patch -d sw/slc7_amd64_gcc630/external/py3-cmsmonitoring/0.6.7-comp/lib/python3.8/site-packages -p 3

@mrceyhun mrceyhun merged commit 4c87b3b into dmwm:master Sep 13, 2022
@mrceyhun
Copy link
Contributor

@amaltaro Changes are fine with me, thanks for the pylint fixes :) Here is the new release from this PR CMSMonitoring==0.6.8 : https://pypi.org/project/CMSMonitoring/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants