-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nano flavours T0 #5031
base: master
Are you sure you want to change the base?
Support nano flavours T0 #5031
Conversation
This PR goes hand in hand with LinaresToine/WMCore#6 |
3858524
to
a5d4318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
etc/ProdOfflineConfiguration.py
Outdated
@@ -237,6 +237,7 @@ | |||
siteWhitelist = ["T2_CH_CERN", "T1_UK_RAL", "T1_DE_KIT", "T1_FR_CCIN2P3", "T1_ES_PIC", "T1_IT_CNAF", "T2_CH_CERN_P5"], | |||
raw_to_disk=False, | |||
aod_to_disk=True, | |||
nano_flavours=[',NANO:@PHYS+@L1'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the default should be nano_flavours=['@PHYS, '@L1'],
The ,NANO:
part is added in CMSSW.
@@ -1063,7 +1067,7 @@ def releasePromptReco(tier0Config, specDirectory, dqmUploadProxy): | |||
specArguments['AlcaSkims'] = datasetConfig.AlcaSkims | |||
specArguments['PhysicsSkims'] = datasetConfig.PhysicsSkims | |||
specArguments['DQMSequences'] = datasetConfig.DqmSequences | |||
|
|||
specArguments['NanoFlavours'] = datasetConfig.NanoFlavours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be nanoFlavours
according to https://github.com/cms-sw/cmssw/blob/master/Configuration/DataProcessing/python/Reco.py#L72 ?
0405640
to
73fd6e5
Compare
73fd6e5
to
304689b
Compare
This PR intends to support nano flavours in primary datasets. The current need for it is to enable scouting nano and standard nano in the ScoutingPFMonitor primary dataset.