Only add replicas if parent block has been properly added/attached into Rucio

[amaltaro]

Fixes #10022

Status

ready

Description

Only inject a file replica into Rucio if the parent block (block which the file belongs to) has been successfully inserted into Rucio AND attached to its parent container. Which means, if the block name is in our memory cache, block has been successfully inserted and we can insert its files as well.

Is it backward compatible (if not, which system it affects?)

yes (but we need to assess the damage already made and recover those)

Related PRs

None

External dependencies / deployment changes

None

[cmsdmwmbot]

Jenkins results:

• Unit tests: succeeded
• Pylint check: failed
  • 11 warnings and errors that must be fixed
  • 19 warnings
  • 17 comments to review
• Pycodestyle check: succeeded
  • 9 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10591/artifact/artifacts/PullRequestReport.html

[amaltaro]

Tests went fine and it catches that specific case where the block fails to get attached to the container.
@todor-ivanov can you please review it? I'll likely backport it to wmagent branch, while this one remains open until you can have a look at it.

[todor-ivanov]

Looks good to me

[amaltaro]

Thanks Todor!

[amaltaro]

As reported to Nick, only these 2 blocks were found without an association with their parent containers:

/GMSB_L-400TeV_Ctau-10000cm_TuneCP5_13TeV-pythia8/RunIIAutumn18NanoAODv7-Nano02Apr2020_102X_upgrade2018_realistic_v21-v1/NANOAODSIM#44eb4b62-0b6a-4959-8c7c-5a2bed4ce16d
/Zprime_NonUniversalSSM_M4000_gl0p5_gh0p5_mg_pythia8_TuneCP5/RunIIAutumn18NanoAODv7-Nano02Apr2020_102X_upgrade2018_realistic_v21-v1/NANOAODSIM#1a2e32c5-b350-4140-adce-cba0cb2c2019

and those were fixed yesterday. It's not impossible that there were other cases, for agents that have already been redeployed and logs are no longer available.