Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate useRucio parameter within MicroServices; remove PhEDEx logic from MSOutput/MSMonitor #10094

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Nov 23, 2020

Fixes #10093
Fixes #10052
Fixes #9996

Status

not-tested

Description

As the title says, no longer verify which Data Management system to be used, Rucio becomes the only option now.
In addition to this, removed all the DDM/PhEDEx base code from the MicroServices (MSCore/MSMonitor/MSOutput).

Is it backward compatible (if not, which system it affects?)

no, in the sense of no longer supporting PhEDEx.

Related PRs

none

External dependencies / deployment changes

Deployment changes: dmwm/deployment#991

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
  • Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 14 warnings
    • 17 comments to review
  • Pycodestyle check: succeeded
    • 3 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10798/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

I still have to run some basic tests, but I don't expect any bad surprises and it's ready for review.

…c from MSOutput/MSMonitor

remove MSOutput defaultGroup parameter
@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
  • Pylint check: failed
    • 4 warnings and errors that must be fixed
    • 14 warnings
    • 17 comments to review
  • Pycodestyle check: succeeded
    • 3 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10807/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

I'd like to get it deployed in testbed this morning, so I'm getting it merged now.
Todor, feel free to leave any comments/review though.

@amaltaro amaltaro merged commit 42df906 into dmwm:master Nov 24, 2020
Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants