add all Rucio lfns2pfns args. to getPFN. Fix #10056 #10122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
amaltaro
reviewed
Dec 1, 2020
belforte
added a commit
to belforte/WMCore
that referenced
this pull request
Dec 1, 2020
|
Jenkins results:
|
|
@belforte thanks Stefano. Could you please squash those 2 commits into a single one? In case you need some instructions on how to accomplish that, I usually refer to this short and clear doc: https://steveklabnik.com/writing/how-to-squash-commits-in-a-github-pull-request |
belforte
force-pushed
the
expandRucioGetPFN-fix-10056
branch
from
f7fc709 to
720130c
Compare
|
rebased and squashed. Yeah. I have added tips from that URL to may cheat sheet and had used already to squash my few commits while testing, so I did not realize it was needed again. Sorry. |
|
Jenkins results:
|
|
Just spotted badly encoded chars in this PR (though a git diff) will get that fixed in another PR. |
This was referenced Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10056
Status
ready
Description
introduce new optional parameters for Rucio.client.getPFN
to be able to use all functionalities of Rucio python lnfs2pfns API as per
https://rucio.readthedocs.io/en/latest/api/rse.html
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
#10121 on CRAB branch 1.3.6.crab
External dependencies / deployment changes
None