[py2py3] Migration at level scr/python/A/B/C - slice 8

[mapellidario]

Fixes #10132

Status

In development

Related PRs

• Previous migration PR: [py2py3] Migration at level scr/python/A/B/C - slice 7 #10284 (slice7, issue [py2py3] Migration at level scr/python/A/B/C - slice 7 #10131 )
• Next migration PR: [py2py3] Migration at level scr/python/A/B/C - slice 9 #10290 (slice9, issue [py2py3] Migration at level scr/python/A/B/C - slice 9 #10133 )

Description

Run futurize and some manual changes on the first batch of src/python/A/B/C.

Strings:

• src/python/WMCore/Services/DBS/DBS3Reader.py: required some re-organization of the strings. This should be tested thoroughly!
  • tracking in [py2py3] validate Services/DBS/DBS3Reader.py - slice 8 #10293

Is it backward compatible (if not, which system it affects?)

It should be. (Any possible cause for errors will we reported here)

External dependencies / deployment changes

Requires python-future in both py2 and py3 environments.

[mapellidario]

Test this please

[cmsdmwmbot]

Jenkins results:

• Unit tests: succeeded
• Pylint check: failed
  • 24 warnings and errors that must be fixed
  • 2 warnings
  • 195 comments to review
• Pylint py3k check: succeeded
  • 0 errors and warnings that should be fixed
  • 0 warnings
  • 0 comments to review
• Pycodestyle check: succeeded
  • 292 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11246/artifact/artifacts/PullRequestReport.html

[amaltaro]

Dario, I made a couple of comments in the code which I believe it needs updating. However, please do let me know if I missed something.

This DBS3Reader module is sort of a DBS2 + DBS3 functionality, making things very confusing and possible outdated... Hopefully things will work out of the box here ;)

[mapellidario]

In any case, I am super-worried of how DBS3Reader manages strings, this is why I created #10293. This will need follow-up, especially when we will switch to py3