Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py2py3] Migration at level scr/python/A/B/C - slice 20 #10349

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

mapellidario
Copy link
Member

@mapellidario mapellidario commented Mar 11, 2021

Fixes #10144

Status

In development

Related PRs

Description

Run futurize and some manual changes on the first batch of src/python/A/B/C.

(any notable change will be reported here)

Is it backward compatible (if not, which system it affects?)

It should be. (Any possible cause for errors will we reported here)

External dependencies / deployment changes

Requires python-future in both py2 and py3 environments.

@cmsdmwmbot

This comment has been minimized.

@cmsdmwmbot

This comment has been minimized.

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
  • Pylint check: failed
    • 105 warnings and errors that must be fixed
    • 18 warnings
    • 243 comments to review
  • Pylint py3k check: succeeded
    • 0 errors and warnings that should be fixed
    • 0 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
    • 68 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11477/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! Thanks Dario.

@amaltaro amaltaro merged commit afa00e0 into dmwm:master Mar 18, 2021
mapellidario added a commit to mapellidario/WMCore that referenced this pull request Jun 18, 2021
mapellidario added a commit to mapellidario/WMCore that referenced this pull request Jun 21, 2021
mapellidario added a commit to mapellidario/WMCore that referenced this pull request Jun 21, 2021
mapellidario added a commit to mapellidario/WMCore that referenced this pull request Jun 21, 2021
mapellidario added a commit to mapellidario/WMCore that referenced this pull request Aug 3, 2021
[py2py3] JobSubmitter_t.py - fix pickle path - test

Revert "[py2py3] JobSubmitter_t.py - fix pickle path - test"

This reverts commit a648e126344f316f2bc905224f8a7b9760f85cb8.
mapellidario added a commit to mapellidario/WMCore that referenced this pull request Aug 3, 2021
@mapellidario mapellidario deleted the 20-10144-py2py3 branch March 10, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
py2py3 slice Issue related to slicing the modernization to py2py3 Python3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[py2py3] Migration at level scr/python/A/B/C - slice 20
3 participants