[py2py3] Migration at level scr/python/A/B/C - slice 25

[mapellidario]

Fixes #10149

Status

Ready

Related PRs

• Previous migration PR: [py2py3] Migration at level scr/python/A/B/C - slice 24  #10371 (slice5, issue [py2py3] Migration at level scr/python/A/B/C - slice 24 #10148 )
• Next migration PR: not open yet (slice7, issue [py2py3] Migration at level scr/python/A/B/C - slice 26 #10150 )

Description

Run futurize and some manual changes on the first batch of src/python/A/B/C.

Strings:

• src/python/WMCore/ReqMgr/Web/*: a ton of changes. need to be validated!
  • such as kwds[str(key)] = str(val)
  • or also:

    from builtins import str as newstr, bytes,
    ...
    def toString(data):
    if isinstance(data, (newstr, bytes)):
        return str(data)  # native-string approach

  • tracked in [py2py3] test str/bytes use in src/python/WMCore/ReqMgr/Web/* #10382

Is it backward compatible (if not, which system it affects?)

It should be. (Any possible cause for errors will we reported here)

External dependencies / deployment changes

Requires python-future in both py2 and py3 environments.

[cmsdmwmbot]

Jenkins results:

• Unit tests: succeeded
  • 43 tests deleted
  • 43 tests added
• Pylint check: failed
  • 16 warnings and errors that must be fixed
  • 9 warnings
  • 204 comments to review
• Pylint py3k check: succeeded
  • 0 errors and warnings that should be fixed
  • 0 warnings
  • 0 comments to review
• Pycodestyle check: succeeded
  • 145 comments to review
• Python3 compatibility checks: succeeded
  • there are suggested fixes for newer python3 idioms

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11565/artifact/artifacts/PullRequestReport.html

[amaltaro]

It looks good to me, thanks Dario.
However, since you say it needs validation, I'm going to patch my private services and run some very basic checks before getting it merged.

[mapellidario]

Perfect, thank you very much, Alan!

[amaltaro]

Very basic checks of the ReqMgr2 GUI do not show anything abnormal. Thanks Dario.