[py2py3] Modernization of last files left out up to now #10768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mapellidario
force-pushed
the
10150-fix
branch
from
0009579 to
3349527
Compare
|
Jenkins results:
|
amaltaro
approved these changes
Aug 26, 2021
| @@ -204,8 +204,8 @@ def __call__(self, parameters): | |||
| # force entire component to terminate | |||
| try: | |||
| self.component.prepareToStop() | |||
| except Exception as ex: | |||
| logging.error("Failed to halt component after worker crash: %s", str(ex)) | |||
| except Exception as ex1: | |||
There was a problem hiding this comment.
it wasn't me, you have to thank pylint for that! ahaha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10150
Status
ready
Description
I used
pylint --py3kto scan wholedmwm/WMCoreand find what have been left out up to now.There is one thing that pylint is complaining about, that i did not update in this
PR is
Implementing __eq__ without also implementing __hash__ (eq-without-hash).Is it backward compatible (if not, which system it affects?)
yes
Related PRs
nope
External dependencies / deployment changes
nope