Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CouchDB 3 Migration: Remove all_or_nothing flag #10780

Closed

Conversation

phenomax
Copy link
Contributor

Status

not-tested

Description

As part of the CouchDB Migration to 3.x ( #8853 ), the all_or_nothing flag has to be removed because
it's no longer present (see apache/couchdb#1235 for a discussion).

Is it backward compatible (if not, which system it affects?)

NO

Related PRs

External dependencies / deployment changes

It depends on CouchDB 3.x

@cmsdmwmbot
Copy link

Can one of the admins verify this patch?

@amaltaro
Copy link
Contributor

test this please

3 similar comments
@amaltaro
Copy link
Contributor

test this please

@amaltaro
Copy link
Contributor

test this please

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python2 Pylint check: failed
    • 19 warnings and errors that must be fixed
    • 5 warnings
    • 89 comments to review
  • Python3 Pylint check: failed
    • 19 warnings and errors that must be fixed
    • 5 warnings
    • 64 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 129 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12407/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

amaltaro commented Sep 1, 2021

Thank you for providing this patch, Max.
This PR seems to resolve 6-8 unit tests, bringing failures down to 80:
https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-WMAgentCouch31-TestAll/lastCompletedBuild/testReport/

However, a deep investigation of the possible impacts with the removal of this all_or_nothing flag is required. I will have to follow this up in the coming weeks.

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12797/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

This has been superseeded by #11011, so I am closing this PR.
Thank you very much, Max!

@amaltaro amaltaro closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants