Skip ErrorHandler cycle if agent configuration fails to be retrieved #10817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
add back setupComponentParam to the init method
|
Jenkins results:
|
|
I'm merging it such that it goes in a new tag, but comments are still welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10778
Status
ready
Description
If
maxRetriesis not in the format of a dictionary, that means the component failed to retrieve the agent configuration from central couch reqmgr_auxiliary db. In such cases, which have been sporadically happening, we should skip the component cycle to avoid a comparison of different data types (which is no longer a valid case in Python3, and an exception is raised).We still need to think about an alarm system for all these components, and which conditions to trigger them, but that is for the future in their own GH issues.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None