Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check of RSE dump root_failed attr in MSUnmerged #10894

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Nov 8, 2021

Fixes #10893

Status

ready

Description

Instead of using both status and root_failed to verify whether the RSE unmerged dump was successful or not, use only the status attribute.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

Deployment changes: dmwm/deployment#1102

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
    • 1 tests no longer failing
  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python2 Pylint check: succeeded
    • 7 warnings
    • 10 comments to review
  • Python3 Pylint check: failed
    • 1 warnings and errors that must be fixed
    • 7 warnings
    • 16 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12550/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro requested a review from todor-ivanov November 8, 2021 08:08
Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amaltaro. All looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSUnmerged fails to parse T1_UK_RAL_Disk stats - root_failed error
3 participants