Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request state diagram with archival done by MS #10899

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

amaltaro
Copy link
Contributor

Fixes #10898

Status

ready

Description

Updated only the transition to *-archived state, which is now (actually for a few months) performed by MSRuleCleaner instead of ReqMgr2.

Is it backward compatible (if not, which system it affects?)

yes

Related PRs

none

External dependencies / deployment changes

none

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python2 Pylint check: succeeded
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12559/artifact/artifacts/PullRequestReport.html

@todor-ivanov
Copy link
Contributor

Hi @amaltaro Sorry for commenting without been asked for a review. I do find the diagram perfect, thanks for updating it. What I also noticed though, is we are missing two requests statuses from the wiki page referring to the diagram [1] - staging and staged.

[1]
https://github.com/dmwm/WMCore/wiki/Request-Status

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks perfect @amaltaro :)

@amaltaro
Copy link
Contributor Author

Thanks for pointing out to what was written in the wiki. I somehow was looking only at the diagram.

@amaltaro amaltaro merged commit 62623dc into dmwm:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request state transition diagram needs to be updated with MS archiving
3 participants