[py3] REST/Server.py - encode to bytes input of hashlib.sha1

[mapellidario]

Fixes #10916

Status

Ready, tested in CRABServer test and preprod instances

This webpage https://cmsweb-testbed.cern.ch/crabserver/ui/ is being server by a build of CRABserver that contiains this fix: https://github.com/mapellidario/WMCore/releases/tag/py3.211209

Since we are building CRABServer against our private repo, which contains this fix, we do not have any hurry in mergins this PR.

Description

Make sure that the input of hashlib.sha1() is bytes.

Is it backward compatible (if not, which system it affects?)

yes

Related PRs

none

External dependencies / deployment changes

none

[cmsdmwmbot]

Jenkins results:

• Python2 Unit tests: succeeded
• Python3 Unit tests: succeeded
  • 1 changes in unstable tests
• Python2 Pylint check: failed
  • 50 warnings and errors that must be fixed
  • 20 warnings
  • 84 comments to review
• Python3 Pylint check: failed
  • 55 warnings and errors that must be fixed
  • 20 warnings
  • 90 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 6 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12612/artifact/artifacts/PullRequestReport.html

[amaltaro]

Thanks again, Dario! It looks good to me (honestly, I thought I have had a PR fixing those throughout WMCore...)

[mapellidario]

honestly, I thought I have had a PR fixing those throughout WMCore..
Yeah! I do not know how and why missed this!