Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CouchDB] Do not sanitize couch url at the component layer #11045

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Mar 17, 2022

Fixes #11044

Status

ready

Description

The CouchServer class inheritance is very large, ending up with the Requests class. So, instead of doing the URL sanitization at the sub-class level, leave it to be done by the parent class (Requests), such that we also get the additional header Authorization defined in the object and pass along in the HTTP requests.

This also applies when loading the spec file at the WorkQueueBackend level, where we let the Requests class take care of the sanitization and auth header (current 3rd commit).

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

It's part of a series of fixes / feature changes required for the migration to CouchDB 3.x, such as:
#11011
#11001
#11039

External dependencies / deployment changes

No hard dependencies, but it's a required change for CouchDB 3.x. So to come with:

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests no longer failing
    • 7 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12888/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 7 tests added
    • 4 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12890/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12891/artifact/artifacts/PullRequestReport.html

fix Couch URL sanitization in CleanCouchPoller

Do not sanitize spec url at WorkQueueBackend module
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 3 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12892/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amaltaro amaltaro merged commit 9bd8f6c into dmwm:master Mar 18, 2022
@amaltaro amaltaro changed the title [CouchDB] Do not sanitize couch url in JobAccountant [CouchDB] Do not sanitize couch url at the component layer Mar 18, 2022
@amaltaro amaltaro deleted the fix-11044 branch May 26, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CouchDB 3.x: JobAccountant/CleanCouchPoller fail to authenticate to localhost CouchDB
3 participants