[CouchDB] Do not sanitize couch url at the component layer #11045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11044
Status
ready
Description
The
CouchServer
class inheritance is very large, ending up with theRequests
class. So, instead of doing the URL sanitization at the sub-class level, leave it to be done by the parent class (Requests), such that we also get the additional headerAuthorization
defined in the object and pass along in the HTTP requests.This also applies when loading the spec file at the WorkQueueBackend level, where we let the
Requests
class take care of the sanitization and auth header (current 3rd commit).Is it backward compatible (if not, which system it affects?)
YES
Related PRs
It's part of a series of fixes / feature changes required for the migration to CouchDB 3.x, such as:
#11011
#11001
#11039
External dependencies / deployment changes
No hard dependencies, but it's a required change for CouchDB 3.x. So to come with: