Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cPickle support #11096

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Remove cPickle support #11096

merged 1 commit into from
Apr 18, 2022

Conversation

goughes
Copy link
Contributor

@goughes goughes commented Apr 13, 2022

Fixes #7110

Status

Not tested

Description

Since we no longer support python2, remove attempts to import cPickle and just import pickle.

Is it backward compatible (if not, which system it affects?)

Only works with python3!

Related PRs

NA

External dependencies / deployment changes

NA

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 84 warnings and errors that must be fixed
    • 19 warnings
    • 218 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13018/artifact/artifacts/PullRequestReport.html

@goughes goughes requested a review from amaltaro April 14, 2022 12:55
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goughes it looks good to me. However, can you also please remove the cpickle reference from this file:
src/python/WMCore/WMSpec/Makers/Handlers/MakeJobSlave.py
?

@goughes
Copy link
Contributor Author

goughes commented Apr 15, 2022

Removed the cPickle reference from MakeJobSlave.py with my latest push. Thanks for catching that @amaltaro!

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 94 warnings and errors that must be fixed
    • 19 warnings
    • 224 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13030/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro self-requested a review April 18, 2022 09:16
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erik! It looks good to go.

@amaltaro amaltaro merged commit 852333a into dmwm:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove try/except import cPickle
3 participants