Remove block open logic from DBS3Reader and WorkQueue #11123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
Jenkins results:
|
|
FYI @belforte Stefano, I removed another DBS3Reader method that wasn't mentioned in the initial GH issue. Please check out the first description of this PR with a summary to make sure it won't catch you by surprise ;) |
|
thanks @amaltaro . No problem for CRAB, none of those was used. |
todor-ivanov
approved these changes
May 1, 2022
There was a problem hiding this comment.
Thanks @amaltaro
Looking good to me. Please give us further info upon testing.
|
|
||
| logging.warning("Open FileBlock located at PNN: %s to use is FileBlock: %s ", pnn, blockRef['Name']) | ||
| return blockRef | ||
| return DbsFileBlock( Name = blockName) |
There was a problem hiding this comment.
Please, add the new line the end of the file :)
more OpenForWriting removals fix DataBlockGenerator removed DBS3Reader listOpenFileBlocks method new line at the end of the module
update unit tests
|
Jenkins results:
|
|
Thanks for the review over the weekend, Stefano and Todor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11120
Partial fix for #11048
Status
not-tested
Description
As described in the issue, this feature was needed back in the days of DBS2.
This PR removes DBS/WorkQueue logic related to:
IsOpenblockIsOpenhas been removedlistOpenFileBlockshas been removed (uselistFileBlocksinstead)getDBSFileBlockhas been removedOpenForNewDatato FalseaddNewFilesToOpenSubscriptionshas been removed, since we no longer add new files to open subscriptions (To be tested: what happens when new elements are pulled down?)Is it backward compatible (if not, which system it affects?)
NO (in the sense that it removes a feature)
Related PRs
PR #11119 will have to be rebased once this one goes through.
External dependencies / deployment changes
None