Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add T3_US_Lancium to resource-control. #11126

Merged

Conversation

todor-ivanov
Copy link
Contributor

Fixes #11125

Status

ready

Description

Adding T3_US_Lancium to the list of resources in the addUSOpportunistic.sh.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@todor-ivanov todor-ivanov requested a review from amaltaro May 3, 2022 16:06
@todor-ivanov todor-ivanov changed the title Add T3_US_Lancium Add T3_US_Lancium to resource-control. May 3, 2022
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todor, with the recent changes to the wmagent-resource-control script, we can now add such resources with a single command. So please make such changes here instead:
https://github.com/dmwm/WMCore/blob/master/deploy/deploy-wmagent.sh#L377

IMO, we could even remove this addUS... script.

Add T3_US_Lancium to deploy-wmagent.sh as well.
@todor-ivanov todor-ivanov force-pushed the feature_Add_T3_US_Lancuim_fix-11125 branch from 1ddcec1 to dd24a37 Compare May 3, 2022 16:46
@todor-ivanov
Copy link
Contributor Author

Hi @amaltaro I did add it to the deploy-wmagent.sh as well, but did not remove it from addUSOpportunistic. We'd better have the two lists consistent at least until we decide to completely get rid of the later.

@todor-ivanov todor-ivanov requested a review from amaltaro May 3, 2022 16:48
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13120/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13118/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Todor, we need to make sure the new resource is available in all the FNAL agents until we get to the next stable release, in June. Can you please confirm which FNAL agents you added this resource to?

@amaltaro amaltaro merged commit eda31a4 into dmwm:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding T3_US_Lancuim as part of the US oportunistic list.
3 participants