Add buildAllDep option && Fix package verstion estimation for ParseSpecCmsswdist. #11132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
vkuznet
requested changes
May 6, 2022
todor-ivanov
force-pushed
the
bugfix_Dep_FixParseSpecCmsswdistRecursiveRun_fix-11131
branch
from
79b3da5 to
e7323bc
Compare
|
Thanks for your review @vkuznet I think I have addressed your comments. Could you please take another look? |
|
Jenkins results:
|
vkuznet
approved these changes
May 6, 2022
amaltaro
reviewed
May 6, 2022
| logging.info("%s: specsAll: \n%s", specfile, pformat(specsAll)) | ||
| logging.info("%s: sepcsPy: \n%s", specfile, pformat(specsPy)) | ||
| if buildAllDep: | ||
| for spec in specsAll: |
There was a problem hiding this comment.
How about replacing these 3 lines by:
DEPS_SPEC.extend(spec)
and then at the very end of this script, filtering to unique dependencies only (list(set(DEPS_SPEC)))?
There was a problem hiding this comment.
that's a valid point. I was just trying to make the intervention as little as possible. But yes lets do it the right way. So I did suggest even shorter path here. Please take a look.
…ecCmsswdist. Fix variable type transition. change DEPS_SPEC type to set && Switch to log level info.
todor-ivanov
force-pushed
the
bugfix_Dep_FixParseSpecCmsswdistRecursiveRun_fix-11131
branch
from
e7323bc to
d3d618a
Compare
|
Jenkins results:
|
|
Jenkins results:
|
amaltaro
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11131
Status
READY
Description
With the current PR we are adding the following options to the
ParseSpecCmsswdist.pyscript--allto be able to parse all spec files not only python relatedAnd we fix version string parsing for non-python packages
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None