Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profile scope #11134

Merged
merged 1 commit into from
May 6, 2022
Merged

Remove profile scope #11134

merged 1 commit into from
May 6, 2022

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented May 6, 2022

Fixes #11133
Partial fix for #10940

Status

ready

Description

Remove profile scope to get token with extended attributes

Is it backward compatible (if not, which system it affects?)

yes

Related PRs

Fix a problem injected with: #11093

External dependencies / deployment changes

none

@vkuznet vkuznet self-assigned this May 6, 2022
@vkuznet vkuznet requested review from amaltaro and todor-ivanov May 6, 2022 12:56
@vkuznet
Copy link
Contributor Author

vkuznet commented May 6, 2022

@amaltaro , @todor-ivanov I simply miss this features and confirmed with IAM team that extended scopes for token attributes should be generated without profile scope. Hope we can merge it quickly

@amaltaro
Copy link
Contributor

amaltaro commented May 6, 2022

Let me update the initial description of this PR to have the proper connections.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13160/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro merged commit d3d7076 into dmwm:master May 6, 2022
@todor-ivanov
Copy link
Contributor

thanks @vkuznet

@amaltaro
Copy link
Contributor

amaltaro commented May 6, 2022

And I merged this without a single approval (bad job Alan!), I approved it only on my mind, sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not restrict scope of IAM token to profile only
4 participants