Give enough time for replication to complete in unit tests #11185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
test this please |
|
Jenkins results:
|
todor-ivanov
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
thanks @amaltaro looks good. I was about to ask why not moving this number of seconds configurable, but then I noticed the "only in unit tests" usage comment in the docstring. So lets move on with it as it is.
|
Exactly. That method is only used by unit tests. Thanks Todor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement to #11001
Status
ready
Description
The original changes provided in #11001 were missing this extra function used to create CouchDB replication task in the unit tests. Pass a 6 seconds sleep to ensure that the task is triggered and that documents get to the expected destination in unit tests.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
Complement to #11001
External dependencies / deployment changes
None