remove all the CMS authz logic from the CouchDB validate functions #11191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
todor-ivanov
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Thanks @amaltaro As widely discussed in a private chat, this is change is now well understood and to me it looks pretty good.
|
I will tighten up authz in ReqMgr2 with this ticket: #6072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11190
Status
ready
Description
This PR removes the couchapp validate functions in all of the WMCore design documents. In practice, it means we no longer evaluate the user CRIC group/roles to decide what that person can or cannot do.
Some operations are still reserved only for CouchDB admins, like write/update to design documents; create/delete database admins and members; create and delete databases. Further information in: https://docs.couchdb.org/en/stable/api/database/security.html
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
Might be related to: dmwm/deployment#1088
External dependencies / deployment changes
CouchApps need to be refreshed on the CouchDB backend nodes. Practically speaking, this directory must be removed before CouchDB gets started:
/data/srv/state/couchdb/stagingarea/couchapps/Doesn't necessarily need CouchDB 3.x, but it's meant for that.