Load credentials when saving spec file in local workqueue #11204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznet
approved these changes
Jul 6, 2022
|
Jenkins results:
|
todor-ivanov
approved these changes
Jul 6, 2022
|
Thanks for the review. A backported version has been created and applied to all the 2.0.4 active agents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11203
Status
ready
Description
We create a brand new object of
CouchServerin the call towmspec.load(). So make sure that credentials are passed to that method when creating it, otherwise it fails to write to the localhost database.Is it backward compatible (if not, which system it affects?)
YES (but should be tested in central services as well)
Related PRs
Complement to #11044
External dependencies / deployment changes
None