Convert bin/workflowCompletion.py to python3-only; fix url bug

[amaltaro]

Fixes #11285

Status

ready

Description

As the title says, this PR fixes a mistake when building the DBS url. In addition to that, python2 code has been removed and this script is python3-only now.

Also worked on pylint fixes and a deprecation warning (see below in the comments)

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 1 new failures
  • 2 changes in unstable tests
• Python3 Pylint check: failed
  • 2 warnings and errors that must be fixed
  • 1 warnings
  • 13 comments to review
• Pylint py3k check: failed
  • 10 errors and warnings that should be fixed
• Pycodestyle check: succeeded
  • 2 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13584/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: failed
  • 3 new failures
  • 1 changes in unstable tests
• Python3 Pylint check: succeeded
  • 1 warnings
  • 6 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 2 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13585/artifact/artifacts/PullRequestReport.html

[todor-ivanov]

Thanks @amaltaro
Looks good to me. I just wonder if all those string refactoring was needed or it was just a working on some pylint warnings.

[amaltaro]

The print function is just pylint fix. As it lives in the scripts, I decided to keep it in a single commit.

It's worth mentioning that I also fixed this deprecation warning (updated initial description as well):

wflowCompletion.py:37: DeprecationWarning: key_file, cert_file and check_hostname are deprecated, use a custom context instead.