Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap DBS3Upload exceptions when fetching child/parent info from wmstats #11352

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

amaltaro
Copy link
Contributor

Fixes #9123

Status

not-tested

Description

Instead of verifying all the possible failures that might have happened when calling the wmstatsserver.getChildParentDatasetMap API, and deciding whether a soft or hard failure needs to get propagated in the component; this PR encapsulates such problems such that the component does not stop its execution.

Error is still reported in the logs and it's also visible through LogDB (through WMStats "error logs" tab).

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 3 tests deleted
    • 1 tests no longer failing
    • 3 changes in unstable tests
  • Python3 Pylint check: failed
    • 3 warnings and errors that must be fixed
    • 6 warnings
    • 44 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 18 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13687/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests deleted
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 8 warnings and errors that must be fixed
    • 7 warnings
    • 84 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 19 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13688/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro merged commit a8d5752 into dmwm:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBS3Upload crashing while contacting WMStats for parentage
3 participants