Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change github actions filter pattern #11355

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Change github actions filter pattern #11355

merged 1 commit into from
Oct 31, 2022

Conversation

khurtado
Copy link
Contributor

@khurtado khurtado commented Oct 31, 2022

Fixes #11336

Status

ready

Description

This filter follows the filter patterns from:
(https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet)
It should match to the production tags in the form of X.Y.Z.something or just X.Y.Z
JENKINS tags do not follow this pattern and will be excluded.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Overwrites the changes in:
#11337
Since for some reason, JENKINS tags were still triggered with this one in the main repository (yet not on my tests on my fork)

External dependencies / deployment changes

GH actions

@khurtado khurtado requested a review from amaltaro October 31, 2022 13:57
@khurtado
Copy link
Contributor Author

@amaltaro Can you try with this change? It worked on my fork.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13696/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank, Kenyi.
I found different places mentioning syntaxes like: '*.*.*' vs *.*.*, but if you tested it, let's give it a try then.

@amaltaro amaltaro merged commit 05f3bda into dmwm:master Oct 31, 2022
@amaltaro
Copy link
Contributor

amaltaro commented Nov 7, 2022

@khurtado Kenyi, I still see a bunch of GH actions with an error message as "Startup failure". I guess it shouldn't even start to run it if the filter expression doesn't match the tag, right? Could you please have another look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter which tags should trigger a PyPi action build
3 participants