Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rucio-clients version from 1.25.5 to 1.29.10 #11368

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Nov 22, 2022

Fixes #11359

Status

not-tested

Description

This pull request updates the python rucio-clients package to the latest stable release, 1.29.10.
It also brings in cmsmonitoring from 0.6.9 to 0.6.10 (to resolve a dependency conflict with jsonschema)

As usual, a few inter-dependent libraries get updated as well.

Is it backward compatible (if not, which system it affects?)

MAYBE

Related PRs

None

External dependencies / deployment changes

cmsdist spec: cms-sw/cmsdist#8196

UPDATE: there are hard dependencies on the cryptography library and changes to the manage script are required, please see #11378 (comment) for further details.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 2 tests deleted
    • 1 tests no longer failing
    • 4 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13750/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13753/artifact/artifacts/PullRequestReport.html

Update CMSMonitoring from 0.6.9 to 0.6.10
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 2 new failures
    • 1 tests no longer failing
    • 3 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13754/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

unit test failures are unstable, so not really an issue here.

Copy link
Contributor

@vkuznet vkuznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine to me but may be we can save time if we'll use only two digits match, e.g. instead of rucio-clients~=1.29.10 we use rucio-clients~=1.29. If I'm not mistaken it will pick up all versions from 1.29, and therefore we'll not need to change our requirements if new version from this major tag is released. Just think about it.

@amaltaro
Copy link
Contributor Author

That might be an option for the future indeed. However, I think I still prefer to have a better control of the software stack packaged with WMCore services. We have some many python libraries - and inner libraries - that I am always concerned that even a minor release change can break things for us.

In addition, we usually do not update python libraries based on their minor versions. Last update for rucio-clients has been last year (hence the large jump from 1.25 to 1.29).
Thanks for the review though.

@amaltaro amaltaro merged commit 9e09e52 into dmwm:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update python rucio-clients package to the latest version (1.29.8?)
3 participants