Update buildrelease.sh to consider release-candidate tags #11370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
vkuznet
approved these changes
Nov 23, 2022
| @@ -56,7 +56,7 @@ echo "Updating version string ..." | |||
| perl -p -i -e "s{__version__ =.*}{__version__ = '$TAG'}g" src/python/WMCore/__init__.py | |||
There was a problem hiding this comment.
Since you're making changes, how about changing this line and get rid of perl. You can replace this with sed and use flag -i which will do replacement in place of given file. Getting rid of perl will reduce dependency chain and shell script can rely on standard UNIX tools rather dedicated programming language.
There was a problem hiding this comment.
Yes, this line is simple to replace. But the helper function is a bit more tricky.
I created an specific issue for this task though: #11372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11369
Status
ready
Description
Updates the buildrelease.sh script such that it does a diff of commits between the correct tags (now including release candidate and 4-digit versions).
It has been tested between 2.1.5rc1 and 2.1.5rc2 and the release notes (CHANGES) have been correctly updated.
Is it backward compatible (if not, which system it affects?)
NO
Related PRs
None
External dependencies / deployment changes
Documentation updated in: https://github.com/dmwm/WMCore/wiki/TaggingAndReleasing#new-tagging-convention