Remove obsolete estimate_ttc parameter to Rucio client calls.

[todor-ivanov]

Fixes #11382

Status

ready

Description

With the current PR we remove the obsolete parameter estimate_ttc from the call to the Rucio client's method get_replication_rule() made by the WMCore Rucio wrapper.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

[todor-ivanov]

Hi @amaltaro

The test I did was a direct test by importing the WMCore Rucio module and executing the call. Here is the result showing that the method is working again:

In [1]: from rucio.vcsversion import VERSION_INFO

In [2]: VERSION_INFO
Out[2]: 
{'final': True,
 'version': '1.29.10',
 'branch_nick': 'release-1.29-LTS',
 'revision_id': '57de65622be650ec1e82be31c9f936adcec07d55',
 'revno': 12097}

In [3]: rucio = Rucio(acct=msConfig['rucioAccount'], hostUrl=msConfig['rucioUrl'], authUrl=msConfig['rucioAuthUrl'])

In [4]: rucio.getRule("367c348c38ee4b868a3cc3b5e2418dfb")
Out[4]: 
{'id': '367c348c38ee4b868a3cc3b5e2418dfb',
 'subscription_id': None,
 'account': 'wmcore_transferor',
 'scope': 'cms',
 'name': '/JetHT/Run2012C-v1/RAW#e759da30-f693-11e1-847a-842b2b4671d8',
 'did_type': 'DATASET',
 'state': 'OK',
 'error': None,
 'rse_expression': 'T1_US_FNAL_Disk|T2_CH_CERN',
 'copies': 1,
 'expires_at': None,
 'weight': 'ddm_quota',
 'locked': False,
 'locks_ok_cnt': 2,
 'locks_replicating_cnt': 0,
 'locks_stuck_cnt': 0,
 'source_replica_expression': None,
 'activity': 'Production Input',
 'grouping': 'DATASET',
 'notification': 'NO',
 'stuck_at': None,
 'purge_replicas': False,
 'ignore_availability': False,
 'ignore_account_limit': False,
 'priority': 3,
 'comments': 'WMCore MSTransferor input data placement',
 'child_rule_id': None,
 'eol_at': None,
 'split_container': False,
 'meta': '"{\\"workflow_group\\": \\"production\\"}"',
 'created_at': datetime.datetime(2021, 9, 13, 20, 19, 15),
 'updated_at': datetime.datetime(2021, 9, 14, 0, 1, 45)}

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 tests no longer failing
  • 3 changes in unstable tests
• Python3 Pylint check: failed
  • 10 warnings and errors that must be fixed
  • 14 warnings
  • 26 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 10 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13817/artifact/artifacts/PullRequestReport.html

[amaltaro]

Thanks Todor. It looks good to me.

[todor-ivanov]

MSMonitor at testbed has been patched by the following set of commands directly at the pod:

wget https://raw.githubusercontent.com/dmwm/WMCore/master/bin/patchComponent.sh && chmod 755 patchComponent.sh

curl https://patch-diff.githubusercontent.com/raw/dmwm/WMCore/pull/11383.patch | sudo ./patchComponent.sh reqmgr2ms

/data/srv/current/config/reqmgr2ms/manage start

And I can now confirm Rucio rules are properly fetched and the workflows are moving:

2022-12-02 10:25:07,971:DEBUG:MSMonitor: Checking transfers for: tivanov_TaskChain_LumiMask_multiRun_HG2212_Val_221130_180438_9198
2022-12-02 10:25:07,991:DEBUG:connectionpool: http://cms-rucio.cern.ch:80 "GET /rules/367c348c38ee4b868a3cc3b5e2418dfb HTTP/1.1" 200 935
2022-12-02 10:25:07,992:INFO:MSMonitor: Rule ID: 367c348c38ee4b868a3cc3b5e2418dfb has a completion rate of: 100.0%
2022-12-02 10:25:07,992:DEBUG:MSMonitor: Rule ID: 367c348c38ee4b868a3cc3b5e2418dfb, DID: /JetHT/Run2012C-v1/RAW#e759da30-f693-11e1-847a-842b2b4671d8, state: OK, grouping: DATASET, rse_expression: T1_US_FNAL_Disk|T2_CH_CERN
...

2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_ReReco_LumiMask_HG2212_Val_221130_180401_5799 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_ReReco_Parents_HG2212_Val_221130_180404_3 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_ReReco_RunBlockWhite_HG2212_Val_221130_180250_5614 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_ReReco_RunBlockWhite_Nvidia_HG2212_Val_221130_180252_5755 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_SC_MultiPU_HG2212_Val_221130_180412_2606 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_TC_6Tasks_Scratch_HG2212_Val_221130_180326_1142 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_TC_PY3_Data_LumiList_HG2212_Val_221130_180432_3233 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_TC_PY3_TTbarPU_HG2212_Val_221130_180434_4255 OK, all transfers completed or above threshold, move it on.
2022-12-02 10:25:08,015:INFO:MSMonitor: tivanov_TaskChain_LumiMask_multiRun_HG2212_Val_221130_180438_9198 OK, all transfers completed or above threshold, move it on.

FYI @amaltaro