Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default rucio account for MSPileUp service #11673

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Update default rucio account for MSPileUp service #11673

merged 1 commit into from
Jul 26, 2023

Conversation

khurtado
Copy link
Contributor

Fixes #11668

Status

on hold # to be tested with the new account once the rules are in place

Description

Change default rucio account for MSPileUp

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

https://gitlab.cern.ch/cmsweb-k8s/services_config/-/blob/prod/reqmgr2ms-pileup-tasks/config.py
and
https://gitlab.cern.ch/cmsweb-k8s/services_config/-/blob/prod/reqmgr2ms-pileup/config.py

External dependencies / deployment changes

New rucio account x DN mapping needs to be in place

@khurtado khurtado requested a review from amaltaro July 25, 2023 15:03
@khurtado
Copy link
Contributor Author

@amaltaro This change would complement the changes in from Valentin
preprod: https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/223
prod: https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/224

and what is still pending is the rucio account x DN mapping
Is this correct?
After that, a new deployment and testing can be done.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests no longer failing
  • Python3 Pylint check: failed
    • 3 warnings and errors that must be fixed
    • 2 warnings
    • 24 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14371/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

@khurtado that's correct. I feel like Eric worked on this account/identities yesterday, but it might be worth it pinging him today.

For the services_config, we are still missing the test pull request, as I see changes only for the preprod and prod branches.

@khurtado
Copy link
Contributor Author

@amaltaro Thanks! I will ping Eric via slack. Also, here is the test branch PR for reference (also in the GH issue comments):

https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/225

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khurtado Kenyi, other than the test module that I left a comment in, everything seems to be fine for me. Can you please take that into consideration and make another review request please.

Please also link the 3 services_config PRs in the initial description of this PR (if not done yet). Thanks

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 1 warnings and errors that must be fixed
    • 2 warnings
    • 5 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14383/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

Thanks Kenyi! This will have to be backported to the 2.2.2_cmsweb branch. I will do so together with #11670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt a different Rucio account in MSPileup: wmcore_pileup
3 participants