Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for non-stable docker image in the CD pipeline #12088

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

amaltaro
Copy link
Contributor

Fixes #11762
Complement to #12005

Status

ready

Description

As reported in this comment:
#12005 (comment)

the latest changes to this CD pipeline are incorrectly skipping the non-stable tag, because the they refer to the same tag.

Explicitly writing -stable in that grep command should solve this problem.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Bug fix for #12005

External dependencies / deployment changes

None

Deal with standard and stable releases in different blocks
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15177/artifact/artifacts/PullRequestReport.html

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/15178/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

amaltaro commented Sep 4, 2024

Unit test failure is completely unrelated (and we have no unit tests for bash scripts).
@todor-ivanov @vkuznet if you have a chance today, I would appreciate it if you could review this PR. Thanks

@amaltaro
Copy link
Contributor Author

amaltaro commented Sep 4, 2024

Thanks Valentin!

@amaltaro amaltaro merged commit 2131894 into dmwm:master Sep 4, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement policy to release stable releases
3 participants